Repository navigation
Pin CI unit tests to Python 3.12 in tests.yml - #181
Conversation
| - name: Set up Python | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: ${{ env.PYTHON_VERSION }} |
There was a problem hiding this comment.
Should we just fold this in? as in python-version: 3.12? If you think it's better as it is then that's fine.
| - name: Set up Python | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: ${{ env.PYTHON_VERSION }} |
There was a problem hiding this comment.
Also, aren't we trying to pin to 3.10?
There was a problem hiding this comment.
The original tests.ymlalready defines PYTHON_VERSION: "3.10" on lines 9-11. I simply wired actions/setup-python@v6 up to that existing variable, so the PR explicitly pins CI to the version we were already targeting. If we'd prefer to move to 3.12 instead, I can update the PR accordingly. Shall we try 3.12 ? @tim-band
There was a problem hiding this comment.
I have tested with PYTHON_VERSION: "3.12" in tests.yml and got CI green.
@tim-band would you prefer to move to 3.12 or stick with 3.10?
Part of #175
The unit test workflow already set
PYTHON_VERSION: "3.10"inenv, but no step used it. Tests ran on whatever Python theubuntu-latestrunner image ships, which changes when GitHub updates the image.This PR adds an
actions/setup-python@v6step that installs${{ env.PYTHON_VERSION }}. CI now runs on Python 3.10, the lowest versionpyproject.tomlsupports (python = ">=3.10,<3.14").This is a first step. Support for Python 3.14 (or newer) will come in a separate PR.