WireMod Closure Update for icaruscode develop by gputnam · Pull Request #913 · SBNSoftware/icaruscode

gputnam · 2026-07-15T00:20:15Z

No description provided.

…e CMakeLists.txt file

…PropertiesData. Also change some MessageFacility calls

…age of SignalROIF, rounding of floats, fixed scaling factors to 1 at al. )

jas1005 · 2026-08-04T12:20:54Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_22_00 SBNSoftware/sbn*@SBN_SUITE_v10_22_00

FNALbuild · 2026-08-04T12:34:24Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-08-04T12:44:09Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-08-04T12:45:32Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-08-04T12:59:52Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

jas1005 · 2026-08-04T13:04:58Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_22_00 SBNSoftware/sbn*@SBN_SUITE_v10_22_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06

FNALbuild · 2026-08-04T13:19:30Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-08-04T13:21:51Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-08-04T13:25:15Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-08-04T13:36:59Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

jas1005 · 2026-08-04T21:38:39Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_22_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_22_00

FNALbuild · 2026-08-04T21:52:23Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-08-04T22:02:02Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-08-04T22:02:42Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-08-04T22:13:17Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

jas1005 · 2026-08-05T01:08:51Z

@francescopoppi, @gputnam, and @hausnerh,

Looks like there are some badly named/linked modules (see end of this comment) that need fixing before this PR can build. The twin PR (#918) for production did not have such errors (or the authors remedied things before I started the release manager's build). Might be good to model things after that PR if it still makes sense with how production has diverged from develop. It's also possible that something was incorrectly propagated from production to develop in the recent migration. Let me know if I should pull over some changes to get things to build if addressing the errors below goes directly against your intention/intuition.

3772: -- =============================================================================
3773: -- SQLITE3: SQLite::SQLite3
3774: -- 
3775: -- Configuring done (37.9s)
3776: CMake Error at /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/CetMakeLibrary.cmake:456 (target_link_libraries):
3777:   Target "WireModifier_module" links to:
3778: 
3779:     sbncode::WireMod_Utility
3780: 
3781:   but the target was not found.  Possible reasons include:
3782: 
3783:     * There is a typo in the target name.
3784:     * A find_package call is missing for an IMPORTED target.
3785:     * An ALIAS target is missing.
3786: 
3787: Call Stack (most recent call first):
3788:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/BasicPlugin.cmake:312 (cet_make_library)
3789:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/compat/art/art::module.cmake:30 (basic_plugin)
3790:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/BasicPlugin.cmake:373 (art::module)
3791:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/BasicPlugin.cmake:373 (cmake_language)
3792:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/compat/art/BuildPlugins.cmake:86 (cet_build_plugin)
3793:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/compat/art/BuildPlugins.cmake:65 (build_plugin)
3794:   icaruscode/icaruscode/WireMod/CMakeLists.txt:168 (simple_plugin)
3795: 
3796: 
3797: CMake Error at /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/CetMakeLibrary.cmake:456 (target_link_libraries):
3798:   Target "WireModifierXXW_module" links to:
3799: 
3800:     sbncode::WireMod_Utility
3801: 
3802:   but the target was not found.  Possible reasons include:
3803: 
3804:     * There is a typo in the target name.
3805:     * A find_package call is missing for an IMPORTED target.
3806:     * An ALIAS target is missing.
3807: 
3808: Call Stack (most recent call first):
3809:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/BasicPlugin.cmake:312 (cet_make_library)
3810:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/compat/art/art::module.cmake:30 (basic_plugin)
3811:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/BasicPlugin.cmake:373 (art::module)
3812:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/BasicPlugin.cmake:373 (cmake_language)
3813:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/compat/art/BuildPlugins.cmake:86 (cet_build_plugin)
3814:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/compat/art/BuildPlugins.cmake:65 (build_plugin)
3815:   icaruscode/icaruscode/WireMod/CMakeLists.txt:206 (simple_plugin)
3816: 
3817: 
3818: -- Generating done (7.1s)
3819: CMake Warning:
3820:   Manually-specified variables were not used by the project:
3821: 
3822:     ICARUS
3823: 
3824: 
3825: CMake Generate step failed.  Build files cannot be regenerated correctly.
3826: 
3827: 
3828: FATAL ERROR: stage cmake FAILED for MRB project ICARUS ICARUS_lar_ci with code 1```

jas1005 · 2026-09-15T04:04:48Z

trigger build larsoft@v10_24_00 LArSoft/lar*@LARSOFT_SUITE_v10_24_00 SBNSoftware/sbnalg@v10_24_00 SBNSoftware/sbnobj@v10_23_00 SBNSoftware/sbnanaobj@v10_23_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_24_00 SBNSoftware/icarusalg@v10_24_00 SBNSoftware/icarusutil@v10_24_00 SBNSoftware/icarus_signal_processing@v10_24_00

FNALbuild · 2026-09-15T05:21:25Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-09-15T05:33:12Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-09-15T05:36:53Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-09-15T05:44:08Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

jas1005 · 2026-10-17T05:25:42Z

trigger build larsoft@v10_27_00 LArSoft/lar*@LARSOFT_SUITE_v10_27_00 SBNSoftware/sbnalg@v10_27_00 SBNSoftware/sbnobj@v10_27_00 SBNSoftware/sbnanaobj@v10_27_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_27_00 SBNSoftware/icarusalg@v10_25_00 SBNSoftware/icarusutil@v10_24_00 SBNSoftware/icarus_signal_processing@v10_25_00 SBNSoftware/icarusalg@v10_25_00

FNALbuild · 2026-10-17T05:39:59Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-10-17T05:42:20Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-10-17T05:45:24Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-10-17T05:53:39Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

jas1005 · 2026-10-17T06:08:33Z

@francescopoppi, @hausnerh, and @gputnam,

Seems this PR is still having some build issues even after SBNCode PR 663 was merged. A Slack conversation with us four has more details on why SBNCode PR 663 was needed. Current build issues can be found in CI build 15515, and a snippet of what the error seems to be is pasted below:

692: -- =============================================================================
693: -- === *** Start of configuration of icaruscode ***
694: -- ===
695: -- Found SQLite3: /cvmfs/larsoft.opensciencegrid.org/products/sqlite/v3_40_01_00/Linux64bit+3.10-2.17/include (found version "3.40.1") 
696: -- Found SQLite3: /cvmfs/larsoft.opensciencegrid.org/products/sqlite/v3_40_01_00/Linux64bit+3.10-2.17/include  
697: CMake Error at /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/private/CetOverrideFindPackage.cmake:177 (_find_package):
698:   By not providing "Finddk2nugenie.cmake" in CMAKE_MODULE_PATH this project
699:   has asked CMake to find a package configuration file provided by
700:   "dk2nugenie", but CMake did not find one.
701: 
702:   Could not find a package configuration file provided by "dk2nugenie" with
703:   any of the following names:
704: 
705:     dk2nugenieConfig.cmake
706:     dk2nugenie-config.cmake
707: 
708:   Add the installation prefix of "dk2nugenie" to CMAKE_PREFIX_PATH or set
709:   "dk2nugenie_DIR" to a directory containing one of the above files.  If
710:   "dk2nugenie" provides a separate development package or SDK, be sure it has
711:   been installed.
712: Call Stack (most recent call first):
713:   /cvmfs/larsoft.opensciencegrid.org/products/cmake/v3_27_4/Linux64bit+3.10-2.17/share/cmake-3.27/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
714:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/private/CetOverrideFindPackage.cmake:146:EVAL:1 (find_dependency)
715:   /cvmfs/larsoft.opensciencegrid.org/products/cetmodules/v3_24_01/Modules/private/CetOverrideFindPackage.cmake:146 (cmake_language)
716:   icaruscode/CMakeLists.txt:59 (find_package)
717: 
718: 
719: -- Configuring incomplete, errors occurred!
720: 
721: 
722: FATAL ERROR: stage cmake FAILED for MRB project ICARUS ICARUS_lar_ci with code 1
723: 
724: 
725: real	1m9.811s
726: user	0m14.334s
727: sys	0m21.665s
728: DEBUG cmd res: 1
729: 2026-10-17 00:53:27
730: Ending phase buildICARUS
731: Done 1

francescopoppi · 2026-11-06T16:32:32Z

@jas1005 can you try rerunning the build with the latest develop version?

PetrilloAtWork · 2026-11-06T17:22:26Z

Supposedly solved by SBNSoftware/sbncode#684.

jas1005 and others added 30 commits July 14, 2026 17:56

Add SBNCode and SBNAnaObj to packages required in top-level ICARUSCod…

de23932

…e CMakeLists.txt file

add WireMod in X vs theta_XW

e3340a1

add ratio file

83fe398

reintroduce shifted Edep handling

8c80649

use WireToChanROI module

54edc06

drop dropables

dce3565

reorder some ops

756d377

Better ratio file handling

82d6df5

Add handling for non-global x coordinate

65986a4

Get an offset from the difference in the BackTracker and the Detector…

cdab233

…PropertiesData. Also change some MessageFacility calls

Add dummy scaling to WireModXXW

be30da3

Add fhicls

9184342

add WireModifierXXW.fcl

8bae05d

give optional YZ correction to XXW modifications

64136cd

Add optionality to TGraphs per plane

40ca7b3

Add catch blocks for depositions without a TPC or Wire

1c28cc4

Update wiremod fcls

03f6efb

Update WireMod asserts to exceptions

6b3a77e

Remove stale config.

4e8df53

Update ratio .root files.

7d3dd09

Update WireModifierXXW to new WireModUtility interface.

41cb4b1

Fix fcl inherit path.

2a03fa8

Remove old WireMod fcl file.

92216b8

Fix non-larcv Run 4 wiremod fcl file.

e7207e2

Addition of some WireMod diagnostic tools, addition of some flags (us…

ffb1490

…age of SignalROIF, rounding of floats, fixed scaling factors to 1 at al. )

Build fixes.

3f2333d

Change truth matching to use SimChannel's instead of SimEnergyDeposit's

a659b0c

Add thxw resolution check to Diagnostic module.

238fa8e

Fix dummy hit finder config to match the nominal hit finder.

b94ccd2

Fix thXW calculation.

8be3387

jas1005 force-pushed the develop branch from 8c0dc27 to edcb4d4 Compare November 7, 2026 18:39

Conversation

gputnam commented Jul 15, 2026

Uh oh!

jas1005 commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

jas1005 commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

jas1005 commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

FNALbuild commented Aug 4, 2026

Uh oh!

jas1005 commented Aug 5, 2026

Uh oh!

jas1005 commented Sep 15, 2026

Uh oh!

FNALbuild commented Sep 15, 2026

Uh oh!

FNALbuild commented Sep 15, 2026

Uh oh!

FNALbuild commented Sep 15, 2026

Uh oh!

FNALbuild commented Sep 15, 2026

Uh oh!

jas1005 commented Oct 17, 2026

Uh oh!

FNALbuild commented Oct 17, 2026

Uh oh!

FNALbuild commented Oct 17, 2026

Uh oh!

FNALbuild commented Oct 17, 2026

Uh oh!

FNALbuild commented Oct 17, 2026

Uh oh!

jas1005 commented Oct 17, 2026

Uh oh!

francescopoppi commented Nov 6, 2026

Uh oh!

PetrilloAtWork commented Nov 6, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants