Repository navigation
Fixed CAFMaker/RecoUtils dependencies - #685
Merged
Merged
Conversation
The dependencies in there are now optimal. Changes were needed in dependent code with missing inclusions that were covered by RecoUtils. The changes to this other code are minimal rather than optimal.
jas1005
approved these changes
Nov 6, 2026
jas1005
left a comment
jas1005
left a comment
There was a problem hiding this comment.
I have tested this in a local build and can confirm this allows ICARUSCode to build with the latest light-fix additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependencies in there are now optimal.
Changes were needed in dependent code with missing inclusions that were covered by
RecoUtils.The changes to this other code are minimal rather than optimal.
The original code prevented building
icaruscodestand-alone.