Skip to content

Fix Linux CI build: install cmake and build tools explicitly - #324

Closed
julianlitz wants to merge 8 commits into
mainfrom
litz_install
Closed

julianlitz wants to merge 8 commits into
mainfrom
litz_install

Conversation

@julianlitz

Copy link
Copy Markdown
Collaborator

AI generated

Problem

The install-and-build (backend=openmp) job fails at the Build step with
cmake: command not found (exit code 127). The build and test actions only
install lcov and rely on the gyselalibxx_env:latest container image to provide
cmake, make and a compiler. That image is no longer guaranteed to provide them
(or put them on PATH), so CI breaks whenever the latest tag changes.

Changes

  • .github/actions/build: install cmake, make, g++ and git alongside lcov.
  • .github/actions/test: install cmake alongside lcov, since the test action
    runs ctest and cmake --build . --target coverage.
  • Remove the unsupported type: bool field from the composite action inputs
    (GitHub ignores it; inputs are always strings).

Notes

  • The CUDA build action already installs git cmake itself, so it is unchanged.
  • The METIS/MUMPS install-dependencies action needs git and cmake; these are
    now installed before it runs.
  • Ubuntu 24.04 ships CMake 3.28. If the project requires a newer version, we
    should switch to pip install cmake instead.

Follow-up (not in this PR)

Consider pinning ghcr.io/gyselax/gyselalibxx_env to a specific tag or digest
instead of latest so upstream image rebuilds cannot break CI unexpectedly.

Testing

CI on this PR: install-and-build (openmp, with and without MUMPS) and
run-unit-test should pass.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@julianlitz julianlitz closed this Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (7d11dd1) to head (be8b6f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          79       79           
  Lines        8643     8643           
=======================================
  Hits         8427     8427           
  Misses        216      216           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant