Repository navigation
Fix Linux CI build: install cmake and build tools explicitly - #324
Closed
julianlitz wants to merge 8 commits into
Closed
julianlitz wants to merge 8 commits into
julianlitz wants to merge 8 commits into
Conversation
Added cmake, make, g++, and git to the installation of lcov.
Added cmake, make, g++, and git to the installation of lcov.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 79 79
Lines 8643 8643
=======================================
Hits 8427 8427
Misses 216 216 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI generated
Problem
The
install-and-build (backend=openmp)job fails at the Build step withcmake: command not found(exit code 127). Thebuildandtestactions onlyinstall
lcovand rely on thegyselalibxx_env:latestcontainer image to providecmake,makeand a compiler. That image is no longer guaranteed to provide them(or put them on
PATH), so CI breaks whenever thelatesttag changes.Changes
.github/actions/build: installcmake,make,g++andgitalongsidelcov..github/actions/test: installcmakealongsidelcov, since the test actionruns
ctestandcmake --build . --target coverage.type: boolfield from the composite action inputs(GitHub ignores it; inputs are always strings).
Notes
git cmakeitself, so it is unchanged.install-dependenciesaction needsgitandcmake; these arenow installed before it runs.
should switch to
pip install cmakeinstead.Follow-up (not in this PR)
Consider pinning
ghcr.io/gyselax/gyselalibxx_envto a specific tag or digestinstead of
latestso upstream image rebuilds cannot break CI unexpectedly.Testing
CI on this PR:
install-and-build(openmp, with and without MUMPS) andrun-unit-testshould pass.Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):