Skip to content

Adapt Linux CI to the Spack-based gyselalibxx_env image - #326

Merged
julianlitz merged 3 commits into
mainfrom
litz_install_3
Nov 3, 2026
Merged

julianlitz merged 3 commits into
mainfrom
litz_install_3

Conversation

@julianlitz

@julianlitz julianlitz commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

AI generated

Problem

Since gyselax/gyselalibxx#852 the gyselalibxx_env image installs its dependencies
with Spack and no longer ships cmake, Kokkos and LAPACK in /opt or the system
paths. The scheduled CI runs have failed since 31 Oct.

Changes

  • build and test actions: activate the gyselalibxx-openmp Spack environment
    (cmake, Kokkos) before configuring, building and running the tests. Drop
    CMAKE_PREFIX_PATH=/opt/openmp.
  • install-dependencies: activate the Spack environment for cmake, install
    gfortran and LAPACK via apt, and bump the METIS/MUMPS cache keys so caches
    built on the old image are not reused. The Spack environment does not provide
    METIS or MUMPS, so they are still built here.
  • Remove the unsupported type: bool from composite action inputs.

Follow-up

Pin the image to a tag/digest instead of latest.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

Updated installation steps to include LAPACK and modified cache keys for METIS and MUMPS.
Removed type definition for 'use-mumps' parameter and added environment setup commands for testing and coverage.
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (7d11dd1) to head (f3b3273).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          79       79           
  Lines        8643     8643           
=======================================
  Hits         8427     8427           
  Misses        216      216           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julianlitz
julianlitz merged commit fd10fe1 into main Nov 3, 2026
9 checks passed
@julianlitz
julianlitz deleted the litz_install_3 branch November 3, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants