Repository navigation
Zigbee Lock: make code sync more robust - #3330
Open
hcarter-775 wants to merge 9 commits into
Open
hcarter-775 wants to merge 9 commits into
hcarter-775 wants to merge 9 commits into
Conversation
|
Invitation URL: |
hcarter-775
changed the title
Test Results 73 files ± 0 550 suites ±0 0s ⏱️ ±0s Results for commit e721024. ± Comparison against base commit 528c7fb. This pull request removes 2 and adds 14 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
zigbee-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against e721024 |
hcarter-775
force-pushed
the
improve-zigbee-sync-codes
branch
2 times, most recently
from
November 4, 2026 22:06
3e1a17a to
34df795
Compare
ctowns
reviewed
Nov 5, 2026
ctowns
left a comment
ctowns
left a comment
Contributor
There was a problem hiding this comment.
If we are adding this here, would we want it for Z-Wave too?
This adds some resiliency to the driver, but do we have an idea of how often we might see a case that requires this? I would guess it is rare, but I still agree it's good to make the driver more robust.
nit: could we update the title of this PR to something more accurate? This isn't really increasing the sync frequency, but rather adding some robustness and retries to confirm that the sync actually completes. It's more of a backup than something periodic that would happen frequently
hcarter-775
changed the title
Contributor
Author
@ctowns, yes, we should probably add this to Zwave too, but I wanted to put that in a separate PR after this merged, to ensure that is as smooth a thing as possible and that I'm not just sitting for 2 same PRs at once. |
hcarter-775
changed the base branch from
main
to
simplify-reported-cred-management
November 5, 2026 20:05
hcarter-775
force-pushed
the
improve-zigbee-sync-codes
branch
2 times, most recently
from
November 6, 2026 17:56
2ddd790 to
b5203db
Compare
hcarter-775
force-pushed
the
simplify-reported-cred-management
branch
from
November 6, 2026 19:59
1eab2cd to
528c7fb
Compare
- skip sync while the device is busy (expiring stale busy state so a stalled sync can be retried) rather than clobbering a command in flight - advance the sync from the persisted code index and ignore responses for any other index - clear the persisted index when it was started under a different CODES_SYNC_VERSION - clear the consecutive unoccupied counter when a sync completes - move continue_code_sync into lock_utils' sync section - start the init sync after a 15s delay (so NumberOfPINUsersSupported is known) and drop the duplicate from doConfigure Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A non-success Default Response to GetPINCode may be transient. Retry the same index once before treating the slot as unoccupied, so a transient failure does not count toward ending (and permanently completing) the sync early. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Also document how CODES_SYNC_VERSION bumps trigger a re-sync. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
hcarter-775
force-pushed
the
improve-zigbee-sync-codes
branch
from
November 6, 2026 20:00
b5203db to
e721024
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Attempt a re-sync of lock codes after migration is completed as a backup measure, in case our local lockCodes cache missed. Also, retry lock codes migration on every driver init, until the sync has actually completed at least once. Also, we should sync codes from 0, since this is technically an index that can be valid, depending on the device.
Summary of Completed Tests
Tested on-device. Unit tests updated and added.