Repository navigation
zigbee-lock: addCredential always creates a new user - #3333
Closed
hcarter-775 wants to merge 1 commit into
Closed
hcarter-775 wants to merge 1 commit into
hcarter-775 wants to merge 1 commit into
Conversation
addCredential has no credentialIndex argument, so its userIndex argument now selects the credential slot (0 auto-assigns). The user is always new and takes the next free user slot. Also accept the master userType, and reject a requested slot that is already occupied. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Channel deleted. |
Test Results 73 files ±0 549 suites ±0 0s ⏱️ ±0s For more details on these errors, see this check. Results for commit 47cf28f. ± Comparison against base commit bb08c2c. This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both. |
|
zigbee-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 47cf28f |
Contributor
Author
|
closing- this is now a commit on top of #3331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
addCredential has no credentialIndex argument, so its userIndex argument now selects the credential slot (0 auto-assigns). The user is always new and takes the next free user slot. Also accept the master userType, and reject a requested slot that is already occupied. This is a useful change in order to allow users to add pin codes at specified slots, if they so choose, via the ST api.
Summary of Completed Tests
Tested on-device. Unit tests updated.