Repository navigation
make tab work in editor - #909
Open
SharonStrats wants to merge 1 commit into
Open
SharonStrats wants to merge 1 commit into
SharonStrats wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change uses CodeMirror’s standard binding and includes a matching registration test, with no blocking issues identified.
No open issues 🎉
What changed in this PR
This PR makes Tab indent within the code editor instead of moving focus to the save control.
Changes:
- Adds CodeMirror’s standard
indentWithTabbinding before the existing keymaps. - Adds a unit test verifying that the Tab binding is registered first.
| File | Description |
|---|---|
test/unit/codeEditor.test.js |
Mocks the indentation binding and tests its keymap placement. |
src/lib/code-editor/CodeEditor.ts |
Imports and registers indentWithTab. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tab inside the editor was going to the save changes instead of tabbing inside the editor.