Skip to content

change message when a user has multiple sharing types on a container … #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SharonStrats wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

change message when a user has multiple sharing types on a container … #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/access-control-modal/AccessControlModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ export default class AccessControlModal extends DialogComponent<void> {
return html`
<div class="access-control-mixed-policy-warning" role="alert">
<strong>This container has different access settings for the folder and its contents.</strong>
<span>Changing this mixed policy is an advanced feature. You can still change access for the folder or its contents separately below.</span>
<span>Currently you can only add and/or update access on the folder and contents combined.</span>
</div>
`
}
Expand Down
2 changes: 1 addition & 1 deletion test/components/access-control-modal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1687,7 +1687,7 @@ describe('AccessControlModal submit', () => {
const warning = element.shadowRoot.querySelector('.access-control-mixed-policy-warning')
expect(warning?.getAttribute('role')).toBe('alert')
expect(warning?.textContent).toContain('different access settings for the folder and its contents')
expect(warning?.textContent).toContain('You can still change access for the folder or its contents separately below.')
expect(warning?.textContent).toContain('Currently you can only add and/or update access on the folder and contents combined.')
expect(element.shadowRoot.querySelector('solid-ui-access-control-add-access')?.disabled).toBe(true)
expect(element.shadowRoot.querySelector('solid-ui-access-control-shared-access')?.disabled).toBe(true)
expect(element.shadowRoot.querySelector('solid-ui-access-control-general-access')?.disabled).toBe(true)
Expand Down
Loading