Repository navigation
Remove PlatformMacros and cleanup some code - #216
Merged
Merged
Conversation
marchc1
approved these changes
Oct 20, 2026
marchc1
left a comment
marchc1
left a comment
Member
There was a problem hiding this comment.
This is fine. We will never ever ever build for console obviously, and especially not the X360 lol
I think we would need the equivalent binaries for the ARM64 Steam API. We also would need someone to test on OSX who has an M-series chip. I do have an Intel Mac I could test on, but we are on OpenGL 4.6 (where OSX cut off at 4.1). Guess someone will have to make ShaderAPIMetal
Member
|
(ShaderAPIMetal is mostly a joke, I am not sure what the best way for OSX support would be, I imagine the easiest would be MoltenVK once we have a Vulkan shaderapi but I also don't have experience with using that in a C# application, so this is entirely just thinking out loud way too early) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added MacOS to the CI so we catch errors early on but I suspect it fails, will add commits fixing them but will be untested since I don't have Apple garbage.