Repository navigation
Raise instead of crashing on misuse of the problem bindings - #35
Closed
Transurgeon wants to merge 1 commit into
Closed
Transurgeon wants to merge 1 commit into
Transurgeon wants to merge 1 commit into
Conversation
Transurgeon
commented
Nov 9, 2026
Member
- Derivative calls before their init step segfaulted; they now raise RuntimeError naming the init call to make.
- u, lagrange and theta lengths were unchecked, so the engine read past the buffer and returned wrong values; they now raise ValueError.
- update_params with no parameters, and register_params with a constant node, called exit(1) in the engine; they now raise ValueError first.
- Derivative calls before their init step segfaulted; they now raise RuntimeError naming the init call to make. - u, lagrange and theta lengths were unchecked, so the engine read past the buffer and returned wrong values; they now raise ValueError. - update_params with no parameters, and register_params with a constant node, called exit(1) in the engine; they now raise ValueError first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.