Repository navigation
Copy Parameter values on assignment - #39
Merged
Merged
Conversation
Parameter.value = arr kept a view of arr for 1-D, vector and F-ordered float64 input. Editing arr in place then changed p.value without bumping the parameter version, so the engine kept the old values until some other Parameter was assigned. Part of #37 (item 4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameter.value = arrkept a view ofarrwhen no conversion was needed (1-D,(n, 1)/(1, n)and F-ordered float64 input). Editingarrin place then changedp.valuewithout bumping the parameter version, so the engine kept the old values until some unrelated Parameter was assigned:The same in-place edit could also make a
quad_formQ non-symmetric after it had passed the symmetry check.The fix copies the flattened value in the
Parameter.valuesetter. It addstest_parameter_value_is_copied, which fails on main.Part of #37 (item 4).
🤖 Generated with Claude Code