Repository navigation
feat(connections): pass connection details to scripts, add Redshift IAM sign-in - #3715
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TABLEPRO_CONNECTION_NAME,TABLEPRO_HOST,TABLEPRO_PORT,TABLEPRO_USER,TABLEPRO_DATABASE. Never the password. Host and port are the typed ones, not a tunnel's loopback.{host},{port},{user},{database}become quoted references to the sameTABLEPRO_*variables, which are exported too, so a value is never parsed as code.reuseSecondsin connections.json, Reuse Result For in the profile editor. In memory only, dropped on a failed connect.GetClusterCredentialsWithIAM, orGetClusterCredentialswhen Username is set; Serverless usesGetCredentials. The returned user and password sign in, Backup Dump included. The endpoint comes from Host (exact AWS names only) or Redshift Endpoint behind a port forward./usr/local/binpaths a Dock launch lacks, stop with their process group on timeout or cancel, and a self-signal is a failure, not a timeout.$VARis left to bash instead of being expanded from TablePro's environment first.RegistryAWSIAMFieldsTests.excludedTypesHaveNoIAMpinned "Redshift has no IAM"; Redshift now has its own test there.Test plan
ConnectionScriptContextTests,ConnectionScriptRunnerTests,PostDisconnectScriptsTests,RedshiftIAMSignInTests(SigV4 signature checked against an independent computation). New cases inPreConnectScriptEntryPointTests,PreConnectScriptConsentTests,PasswordSourceResolverTests,PasswordSourceCodableTests,ShareableAdditionalFieldsTests.TableProImportTestsandIOSConnectionExportServiceTestspass. Lint, l10n and docs checks pass.Fixes #2498
Fixes #2494