Repository navigation
feat(datagrid): choose the format Cmd+C copies rows in - #3718
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
October 20, 2026 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd+C) writes for whole rows: TSV (default), TSV with Headers, JSON, CSV, CSV with Headers, Markdown.ShortcutUniquenessTestspins the unbound count, now 29 (was 22).Cmd+Vin a table or a data file pastes the rows, not the parsed text. A data file maps a copy of its own columns by name, and anything else in order.Test plan
RowCopyFormatTests(new): with CSV with Headers, three selected rows copy as a header line and three CSV lines (fails on main, which writes TSV). Also covers a row picked by number, a focused cell, a cell range, a Structure-style grid, the right-click Copy, Copy Cell Value, the Copy Special commands, IN Clause columns, INSERT and UPDATE availability, data file paste, held rows and the row cap.SettingsFieldDecodingTests: settings without the field, or with an unknown format, decode to TSV.Not in this PR
RowEditingCoordinator), not the grid. Over a cell selection they take every visible column, while the right-click Copy as takes the selected ones. Copy with Headers from the menu bar also writes no HTML.DataFileSplitViewControllerdoes not implement them.dataGridCopyRows.KeyHandlingTableView.copyRowsAsTSV(_:)has had no menu item since refactor(coordinator): delete dead AppCommands subjects, PasteboardActionRouter, and unused selectors #1340. Only its tests call it.Pairs with TableProApp/docs#75.
Fixes #2496