Repository navigation
test(shortcuts): list the unbound actions by name instead of counting them - #3744
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShortcutUniquenessTests.unboundActionsAreCounted("Thirty actions ship unbound"), nowunboundActionsAreListed("Only the listed actions ship unbound"): it pins the 31 unbound actions by name instead of a count.pinTab) and feat(datagrid): write one typed value into every selected cell #3717 (setCellsToValue) each bumped the count from 29 to 30 and merged cleanly into 31.newlyRebindableCommandsAreListablealso covers.pinTab.Test plan
ShortcutUniquenessTestsfails on main (31 unbound, 30 expected) and passes here.DefaultShortcutHygieneTests,ShortcutConflictTests,ReservedShortcutTests,KeyboardSettingsSanitizeTests,KeyboardSettingsMigrationTests,ShortcutHintTests,BareKeyValidationTests,MainMenuShortcutCoverageTestspass.