Skip to content

fix: include recently left companies in breakdown counts - #1445

Closed
tannerlinsley wants to merge 1 commit into
taren/live-company-prioritizationfrom
taren/live-company-chart-counts
Closed

tannerlinsley wants to merge 1 commit into
taren/live-company-prioritizationfrom
taren/live-company-chart-counts

Conversation

@tannerlinsley

Copy link
Copy Markdown
Member

When Include recently left is checked, the company grid and facet menus include those companies, but the breakdown charts still count only active companies. Pass the same filter to the chart counts so they agree.

Stacked on #1444. Addresses the finding in #1444 (comment).

Validation: pnpm test passed, including typechecks, lint, unit, chat and desktop suites. The 11 company helper and Scarf report tests also passed independently with mocked reporting responses.

@changeset-bot

changeset-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1cfadc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 64200e98-6e78-4e83-9d95-582a61785eba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 1cfadc1 Commit Preview URL

Branch Preview URL
Oct 29 2026, 06:55 PM

@tannerlinsley

Copy link
Copy Markdown
Member Author

Closing this follow-up because #1444 now includes the same chart-count fix. The fix remains tracked there.

AI review notes:
Independently verified that #1444 at 8c9ae72 and this PR at 1cfadc1 have identical Git trees. The focused checks and full repository tests previously run for this PR therefore cover the same source tree. Both PRs have passing application checks. #1444 is still open, so this closure does not mean the fix has shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant