You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: preserve OAuth grants when refreshing legacy-scope tokens - #1451
Refreshing an API token without a resource dropped its grant ID, so revoking the refresh token left the new access token valid. Preserve the grant ID when issuing that access token.
Targets #1449. Tokens created before grant IDs existed still need separate legacy revocation handling.
AI review notes:
Added a PostgreSQL regression that issues a grant without a resource, refreshes it, revokes the refresh token, then checks the refreshed access token. It fails on the parent commit and passes with this change. All seven database tests passed against a disposable local PostgreSQL 17 database.
Full repository validation passed through the normal commit hooks: types, lint, 627 unit tests, 2,278 chat tests, and 20 desktop tests. The suites skipped 5, 7, and 1 tests respectively. The seven PostgreSQL tests were run separately against the disposable database.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 41a0012a-f5e0-4548-95bf-994f20d6803c
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
🔍 Trigger review
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshing an API token without a resource dropped its grant ID, so revoking the refresh token left the new access token valid. Preserve the grant ID when issuing that access token.
Targets #1449. Tokens created before grant IDs existed still need separate legacy revocation handling.