Repository navigation
fix: preserve existing file mode in atomic_write - #3
Draft
PavanaSakethaRam wants to merge 1 commit into
Draft
PavanaSakethaRam wants to merge 1 commit into
PavanaSakethaRam wants to merge 1 commit into
Conversation
Keep the original Unix permissions on the temporary file before it replaces an existing file. Cover replacement and new-file behavior with regression tests. Refs #2 Signed-off-by: Pavan Saketh Ram <pavan.sakethram@gmail.com>
PavanaSakethaRam
force-pushed
the
fix/issue-2-20261019173248-cdffd791
branch
from
October 19, 2026 17:48
5a89ec5 to
8fe6d0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atomic_writereplaces it.Verification
develop(0600instead of0644) and passes with this change.cargo fmt --all -- --checkcargo clippy --workspace --all-targets --locked --offlinecargo test --workspace --locked --offline(952 passed, 3 ignored)cargo clippy --no-default-features --all-targets --locked --offlinecargo test --no-default-features --locked --offline(952 passed, 3 ignored)cargo doc --no-deps --locked --offlineFixes #2
Jarvis produced the initial regression and patch, but reached its request limit before its publication step. I reviewed, refined, and verified the patch locally before opening this draft.