Repository navigation
fix: resolve issue #4 - #5
Draft
PavanaSakethaRam wants to merge 1 commit into
Draft
PavanaSakethaRam wants to merge 1 commit into
PavanaSakethaRam wants to merge 1 commit into
Conversation
Signed-off-by: Pavan Saketh Ram <pavan.sakethram@gmail.com>
PavanaSakethaRam
force-pushed
the
fix/issue-4-20261019180629-72b44161
branch
from
October 19, 2026 18:10
dda1bbf to
95d47d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause was the regex pattern in
strip_ansiat src/utils.rs:50 which only matched digits and semicolons ([0-9;]*) inside CSI sequences. Colon-separated SGR parameters (e.g.,\x1b[38:2:255:0:0mfor truecolor) were not recognized. The fix expands the character class to[0-9;:]*to also match colons. All 34 utils tests pass, including the new regression test and all existing strip_ansi tests.Refs #4
Reproduction and validation
Regression:
utils::tests::bugfix_issue_4_test_strip_ansi_colon_sgr. Confirmed failing on the baseline plus the new test (observed assertion:assertionleft == rightfailed), and passing with the implementation change.cargo test --bin rtk --locked --offline utils::tests::bugfix_issue_4_test_strip_ansi_colon_sgr -- --exact --nocapture --test-threads=1: passedcargo fmt --all -- --check: passedcargo clippy --workspace --all-targets --locked --offline: passedcargo test --workspace --locked --offline: passedcargo clippy --no-default-features --all-targets --locked --offline: passedcargo test --no-default-features --locked --offline: passedcargo doc --no-deps --locked --offline: passedVerified tree:
b9da47ad1057c6e609328ba37598a31fb89bf72c.Generated by the RTK Bugfix Agent. Local Linux verification is recorded; upstream CI, maintainer review, and any required CLA action remain separate.