Repository navigation
Conversation
… export The cardinality of a specification is set by minOccurs and maxOccurs on its applicability: required is 1 and unbounded, optional is 0 and unbounded, prohibited is 0 and 0. They were ignored on load and always written as 1 and unbounded on export, so an optional or prohibited specification came back required. Read both on load into IDSSpecification.minOccurs and maxOccurs (default 1 and unbounded) and write them back on export.
…verdict A required specification fails when too few elements are applicable, a prohibited one fails when any is, and an optional one may pass with none (IDS developer guide, Optionality). The requirements of a prohibited specification are ignored. The existing test() is unchanged. verify() returns the verdict, the number of applicable elements and the same per-element result as test().
rihokirss
marked this pull request as draft
November 7, 2026 19:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the remaining IDS 1.0 conformance cases: IFC2X3 occurrence/type mapping, material inheritance and cardinality, SI conversion for explicit and project units, predefined and material properties, numeric equality tolerance, and combined XSD restrictions. XML import preserves lexical strings; export preserves constraints and descriptions. Specification results expose applicable item identities and keep requirement checks in document order.
This is an integration branch depending on the existing work in #814, #816, #822 and #852, and on #853, #854 and #855. Their commits are included unchanged; the new changes extend them. The upstream implementations are reused rather than reimplemented in a consumer adapter. The dependency commits can be dropped as their respective PRs merge.
Validation:
The existing property applicability regression now also asserts the type object's own property set. An attribute-only applicability can select a type object as well as its instances, as required by the general IDS facet semantics.