Repository navigation
feat(cli): seed retained OpenNext cache with bucket-scoped S3 - #6
Closed
WillieCubed wants to merge 2 commits into
Closed
WillieCubed wants to merge 2 commits into
WillieCubed wants to merge 2 commits into
Conversation
Use the existing account-owned deployment token to derive ephemeral in-memory S3 signing credentials after fixed account self-verification. This avoids requiring an account-wide R2 REST grant for bucket-selected object policies. Require an explicit transport for future cache candidates, preserve the native REST option without fallback, and bind transport, endpoint and byte inventory to candidate-scoped journals. Bound HTTP exchanges and cache inventories, verify full readback digests, reconcile resumed objects, and recheck approval immediately before every PUT attempt. Preserve immutable v0.1.8 consumers. Document the DNS/deadline boundary and pending signing/provider acceptance. Migrate four existing REST fixture declarations without changing their cases or assertions. Ruff, Python compilation and diff checks passed; no tests ran under the task restriction. No release version or dependencies changed. Co-authored-by: Codex <noreply@openai.com>
Cloudflare deployment lists retain result_info, so the shared transport returns an envelope instead of the direct deployment object expected by recovery. Normalize this endpoint without changing generic pagination. Reject malformed rollout rows and ambiguous envelopes before selecting one complete version. Static Ruff, Python syntax and diff checks passed. No tests were added or manually run, and provider recovery acceptance remains pending. Co-authored-by: Codex <noreply@openai.com>
Contributor
Author
|
Superseded by #9, now merged as 37fe36f. The company websites now use native OpenNext/Wrangler commands, and the custom website release/cache machinery this draft extends has been removed from the shared release engine. The six changed paths contain only that website/S3/recovery slice; no unrelated work was identified. Closing this draft without merging, deleting its branch, publishing a release, or changing provider resources. Its source and prior acceptance limitations remain in the retained branch and PR history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Prepare an explicit bucket-scoped S3 transport for retained OpenNext cache seeding and fix Worker recovery capture's handling of Cloudflare's paginated deployment envelope. This is an unreleased source change; published v0.1.8 stays immutable.
Changes
s3orwrangler-restcache transport. Preserve candidate/environment/bucket identities, raw-byte readback, bounded operations, partial journals, and authorization before every PUT/retry and final Worker upload. No automatic REST fallback.wrangler-rest; preserve all existing cases and assertions. No tests were added or manually run.result/result_infoenvelope for recovery. Reject malformed or ambiguous envelopes, invalid version rows, and mixed active rollouts. Generic transport and custom-domain pagination remain unchanged. This addresses the response-shape failure retained from hosted recovery capture 38165763297.Evidence:
8f50e00806bed7996788e490c0d46636ad6f62fe: Python discovery 200 tests (3 framework skips), Swift 4 tests, separate framework-runtime 2 tests and cache suite 12 tests. These are existing regression checks, including the explicit REST fixtures; they do not establish new S3 transport acceptance.9adbeeb9427b49b96fec995695646cfa196bdda6: both required jobs succeeded, with Python discovery 200 tests (3 framework skips), Swift 4 tests, separate framework-runtime 2 tests and cache suite 12 tests. No manual dispatch or rerun was performed.Follow-ups and Next Work