Skip to content

fix(runner): count parallel results under a hidden relative directory - #1394

Merged
Chemaclass merged 3 commits into
TypedDevs:mainfrom
bfs2021:fix/parallel-hidden-dir-slot
Oct 24, 2026
Merged

Chemaclass merged 3 commits into
TypedDevs:mainfrom
bfs2021:fix/parallel-hidden-dir-slot

Conversation

@bfs2021

@bfs2021 bfs2021 commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Parallel runs omitted results from relative hidden directories because aggregation matched only visible worker directories. A failing hidden test could disappear from the totals.

Fix

Aggregate both hidden and visible worker directories while excluding . and ... Keep result keys unchanged so hidden and visible paths remain distinct and valid keys at the filename limit still fit. The aggregation remains fork-free and compatible with Bash 3.0.

Use separate temporary directories for acceptance fixtures so concurrent runs cannot remove each other's files or existing checkout contents. Add regressions for matching hidden and visible paths, failure exit status, and the filename limit.

Validation

  • Proved the mixed-path regression fails before the fix because parallel mode exits 0 instead of 1.
  • Proved prefixing keys breaks a valid path at the filename limit.
  • All 62 targeted consistency, parallel configuration, and process-budget tests pass.
  • Full sequential and parallel suites pass: 2,670 tests each, zero failures, matching totals (14 skipped and 4 incomplete).
  • make sa and make lint pass.

Closes #1393

Comment thread src/runner/result.sh Outdated

@Chemaclass Chemaclass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@Chemaclass
Chemaclass merged commit e005ee6 into TypedDevs:main Oct 24, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Count parallel results from test files under hidden directories

2 participants