Repository navigation
Run the examples against a VRT server in CI, like examples-js and examples-python - #28
Merged
Merged
Conversation
…mples-python The browser examples now run against a 6.0.0-rc1 server from .github/vrt/docker-compose.yml; Appium and the standalone folder client stay compile-only. Running them showed three breakages that compiling hid: - jdi-light-testng: Surefire 3.6 no longer reads TestNG suite XML, so the retry listener moves to a ServiceLoader file, and JDI Light 1.6 needs Java 21 (java.util.SequencedCollection). CI now uses Java 21, and the example no longer ignores test failures. - allure-junit5-gradle-kts asserted OK, which a new baseline never is; it now fails only on UNRESOLVED. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns examples-java CI with examples-js and examples-python. Until now it only compiled the examples.
CI
6.0.0-rc1server, started from.github/vrt/docker-compose.yml(the same file the other repos use). They wait for it the same way, then runmvn -B test/./gradlew test:jdi-light-testng,playwright,selenium-mavenallure-junit5-gradle-kts,selenide-gradleappium-maven(needs an iOS simulator) andstandalone-from-folder-maven(a CLI for a folder of images) stay compile-only.jdi-light-testngon 21..github/vrt(docker-compose), as in the other repos, so it will propose 6.0.0.Breakages that compiling had hidden
suiteXmlFiles. The suite XML is gone; the retryIAnnotationTransformeris registered viaMETA-INF/servicesandTestNGListenerwas already on@Listeners.java.util.SequencedCollection).maven.compiler.releaseis now 21, and the root README says so.testFailureIgnoreis removed, so a failing test fails the build.OK, which a new baseline never is, so it failed on every fresh server. It now fails onUNRESOLVED, which still shows the diff in the Allure report.ignoreFailures = trueis removed, so the assertion counts.All five examples were run locally against a fresh 6.0.0-rc1 stack and pass.
🤖 Generated with Claude Code