Repository navigation
fix: strip trailing slashes from apiUrl - #124
Merged
Merged
Conversation
An apiUrl such as http://localhost:4200/ produced requests to //builds and //test-runs. The URL is now stripped of trailing slashes whether it comes from the constructor, the builder, VRT_APIURL or vrt.json, as sdk-python does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
apiUrlending in/(e.g.http://localhost:4200/) made the SDK call//buildsand//test-runs. The server accepts that, but sdk-python strips the slash, so the SDKs behaved differently.VisualRegressionTrackerConfig.getApiUrl()now drops trailing slashes, the same as sdk-python's config. Every source goes through it: constructor, builder,VRT_APIURLandvrt.json.Tests (written first, failing before the fix):
shouldStartBuildnow asserts the request path is/builds. The mock server URL ends in/, so before this fix every request in that suite went to//….Real run against
visualregressiontracker/api:6.0.0-rc1(examples-java's CI compose file), withapiUrlhttp://…/and a logging proxy in front of the server:imageUrlPOST //builds,POST //test-runs,PATCH //builds/<id>…//images/<name>POST /builds,POST /test-runs,PATCH /builds/<id>…/images/<name>, serves 200Release: a patch, 5.6.1. Nothing is published automatically: after this merges, the owner tags
5.6.1on master and creates the GitHub release by hand, and JitPack builds from the tag.🤖 Generated with Claude Code