Skip to content

xport: preserve trailing period when reconstructing formats #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanmiller merged 2 commits into from
Oct 20, 2026
Merged

xport: preserve trailing period when reconstructing formats #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86a8faf
xport: preserve trailing period when reconstructing formats
hadley Oct 20, 2026
6f7f7a8
Use canonical SAS format strings in round-trip tests
hadley Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sas/readstat_xport_read.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ static readstat_error_t xport_construct_format(char *dst, size_t dst_len,
}
if (decimals) {
pos += snprintf(pos, dst_len-(pos-dst), ".%d", decimals);
} else if (width) {
pos += snprintf(pos, dst_len-(pos-dst), ".");
}

free(format);
Expand Down
8 changes: 4 additions & 4 deletions src/test/test_list.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,15 +1479,15 @@ static rt_test_group_t _test_groups[] = {
.test_formats = RT_FORMAT_SAS,
.columns = {
{ .name = "VAR1", .type = READSTAT_TYPE_DOUBLE, .format = "10.3", .label_set = "10.3" },
{ .name = "VAR2", .type = READSTAT_TYPE_STRING, .format = "$CHAR3", .label_set = "$CHAR3" }
{ .name = "VAR2", .type = READSTAT_TYPE_STRING, .format = "$CHAR3.", .label_set = "$CHAR3." }
}
},
{
.label = "SAS informats",
.test_formats = RT_FORMAT_SAS7BDAT | RT_FORMAT_XPORT_8,
.columns = {
{ .name = "VAR1", .type = READSTAT_TYPE_DOUBLE, .informat = "10.3" },
{ .name = "VAR2", .type = READSTAT_TYPE_STRING, .informat = "$CHAR3" }
{ .name = "VAR2", .type = READSTAT_TYPE_STRING, .informat = "$CHAR3." }
}
},
{
Expand All @@ -1503,9 +1503,9 @@ static rt_test_group_t _test_groups[] = {
.columns = {
{ .name = "VAR1", .type = READSTAT_TYPE_DOUBLE, .format = "10.3", .label_set = "10.3" },
{ .name = "VAR2", .type = READSTAT_TYPE_DOUBLE, .format = "F", .label_set = "F" },
{ .name = "VAR3", .type = READSTAT_TYPE_STRING, .format = "$CHAR3", .label_set = "$CHAR3" },
{ .name = "VAR3", .type = READSTAT_TYPE_STRING, .format = "$CHAR3.", .label_set = "$CHAR3." },
{ .name = "VAR4", .type = READSTAT_TYPE_STRING, .format = "COMMA10.3", .label_set = "COMMA10.3" },
{ .name = "VAR5", .type = READSTAT_TYPE_DOUBLE, .format = "YYQP1", .label_set = "YYQP1" }
{ .name = "VAR5", .type = READSTAT_TYPE_DOUBLE, .format = "YYQP1.", .label_set = "YYQP1." }
}
},
{
Expand Down
Loading