Repository navigation
Link libiconv on macOS - #418
Merged
Merged
Conversation
libtool links shared libraries on Darwin with -undefined dynamic_lookup, so without -liconv the iconv symbols are left unresolved and iconv_open() is NULL at runtime (seen on macOS 27, where test_readstat segfaults).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃 Written by AI 馃
On macOS, libtool links
libreadstatwith-undefined dynamic_lookup, and configure only adds-liconvfor mingw/cygwin. The iconv symbols are therefore bound flat-namespace and resolve to NULL at runtime, sotest_readstatsegfaults on the firsticonv_open()call. Seen on macOS 27.0.1 / Apple clang 21; presumably older macOS happened to have iconv loaded already.