Repository navigation
feat(payroll-nz): add kiwiSaverStatus and registeredForGST to employee tax - #858
Merged
Merged
Conversation
…e tax Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adam-smith-xero
marked this pull request as ready for review
October 28, 2026 06:35
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
the-chris-mitchell
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns the NZ Payroll
EmployeeTaxschema with the updatedpayrollnz/employeetaxdeveloper documentation, ahead ofkiwiSaverStatusbecoming required onPOST /Employees/{EmployeeID}/Tax.The schema had no
kiwiSaverStatusorregisteredForGSTproperty, so SDK users could not send either field. OncekiwiSaverStatusis enforced, POSTs from the generated SDKs would fail.Changes in
xero-payroll-nz.yaml:kiwiSaverStatus(enum, values from KiwiSaver eligibility options). Required in POST for all tax codes except WT and NSW.registeredForGST(boolean). Required in POST whentaxCodeis WT.isEligibleForKiwiSaverasdeprecated: true, replaced bykiwiSaverStatus.updateEmployeeTax: POST is a full replacement, and omitted fields are treated asnull.x-exampleSDK sample, to sendkiwiSaverStatusinstead of the deprecated field.hasSpecialStudentLoanRatedescription.x-exampledefaultvalues copied fromdeductionCategory(DeductionCategory.NzOther).kiwiSaverContributionsnow usesEmployeeTax.KiwiSaverContributionsEnum.MakeContributions, andscheduleOfAccrualoncreateEmployeeLeaveTypenow usesEmployeeLeaveType.ScheduleOfAccrualEnum.PercentageOfGrossEarnings. Both match the per-language values already in those entries.Notes for review
x-exampleentry follow the existingkiwiSaverContributionsentry. Codegen validation is the real check on these.requiredoroneOf, because they depend on other field values.minimum/maximum. Adding constraints to request properties is a breaking change for oasdiff.Checklist
featcommit titlemasterscripts/api-diff/api-diff.test.shpassesJira: AUP-26301
🤖 Generated with Claude Code