Repository navigation
fix: handle blank push notification config IDs - #1242
Conversation
|
The blank push notification config ID changes pass the local module tests. The latest CI run still has one failure on Windows: Could you please advise whether this is a known Windows/Vert.x test issue or whether you'd like me to investigate it further? |
kabir
left a comment
There was a problem hiding this comment.
I checked the Windows test report. The timeout follows an uncaught IllegalStateException: Response already ended at VertxA2AHttpClient.java:456, where the SSE response pipe is created. That prevents the expected error callback from reaching the test.
This appears to be a separate timing-dependent SSE response-handling issue, unrelated to the push-config changes. A rerun fixed it
|
Thanks @prachisinghal-1 - merging |
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #<issue_number_goes_here> 🦕