Repository navigation
test: extend selected scenarios to REST - #1370
Open
faheem-shah-umer wants to merge 5 commits into
Open
faheem-shah-umer wants to merge 5 commits into
faheem-shah-umer wants to merge 5 commits into
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task_registry.py | 97.78% | 100.00% | 🟢 +2.22% |
| src/a2a/server/events/event_queue_v2.py | 91.79% | 92.27% | 🟢 +0.48% |
| src/a2a/utils/telemetry.py | 90.70% | 91.47% | 🟢 +0.78% |
| Total | 93.12% | 93.16% | 🟢 +0.04% |
Generated by coverage-comment.yml
faheem-shah-umer
marked this pull request as ready for review
October 22, 2026 21:10
Iwaniukooo11
requested changes
Oct 26, 2026
| with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as listener: | ||
| listener.bind(('127.0.0.1', 0)) | ||
| port = listener.getsockname()[1] | ||
| server = uvicorn.Server( |
Member
There was a problem hiding this comment.
Please use httpx.ASGITransport to remove boilerplate code like server setup and port binding
tests/integration/test_end_to_end.py L220 is a good example
| listener.bind(('127.0.0.1', 0)) | ||
| port = listener.getsockname()[1] | ||
| server = uvicorn.Server( | ||
| uvicorn.Config( |
Member
There was a problem hiding this comment.
Aslo, please set up on httpx server per module/session rather than creating new one per test
| @@ -0,0 +1,218 @@ | |||
| import asyncio | |||
Member
There was a problem hiding this comment.
Please drop this file. It checks the test harness rather than the SDK itself and doesn't bring actual coverage
Author
|
Thanks for the review. I’ve switched to httpx.ASGITransport, shared the HTTP setup at module scope, and removed the cleanup test file. The local tests pass. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend simple streaming, terminal-task cancellation and artifact delivery scenarios to run over HTTP+JSON alongside gRPC, covering both current and legacy handlers.
Use a module-scoped Starlette application and HTTPX ASGITransport client. Each scenario binds fresh routes and handler state, with per-test cleanup, while the shared HTTP client closes at module teardown.
Validation on Windows / Python 3.10:
The full suite was not rerun locally for this revision. Earlier Windows runs encountered cross-version subprocess cleanup and FastAPI multiprocessing limitations. Full Linux CI verification remains pending.