Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LlamaModel.detokenizeallocates 32 bytes for each token piece.llama_token_to_piecereturns a negative required size when the buffer is too small. The existingassert n <= sizeaccepts that negative result, then slicing with it silently omits the token bytes. We encountered this with Bangla tokens while requesting echoed prompt probabilities: truncated text offsets broke the evaluator's answer-position lookup.Change
Allocate the returned required size and retry. Reject a negative or oversized retry result instead of slicing invalid data. Reuse the enlarged buffer for subsequent tokens. No model, scoring, native-library or vendor changes.
Validation
1652066e0af45f2313b339670ef9555e8a54e545.make lint: passed across package and tests.CUDA_VISIBLE_DEVICESempty); JUnit evidence saved locally. Earlier offline fixture failures are resolved.Searched existing issues/PRs for detokenize-buffer and token_to_piece fixes; no matching fix found. Prepared with AI assistance; validation scope and limitations are stated above.