Repository navigation
Address integration/v2 review findings: server-leg UTS conformance, migration guide, door options #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Address integration/v2 review findings: server-leg UTS conformance, migration guide, door options #1256
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
33aef1b
Rename ClientOptions.idempotentRestPublishing to idempotentHttpPublis…
sacOO7 3e030d1
Persist the push registration token type by name
sacOO7 f04783f
Complete the 2.0 migration guide
sacOO7 54ee94d
Align the push token note in the migration guide with the migration b…
sacOO7 16fc065
Point README, CHANGELOG and CONTRIBUTING at 2.0
sacOO7 f95c15b
Fix stale :java references in UTS docs and tooling
sacOO7 8852d21
Emit additional agent entries in alphabetical order
sacOO7 412b114
Snapshot options in the door builders and strip the opposite side
sacOO7 0b82c58
Test the door side flags on the wire and the device error path
sacOO7 786cc9d
Forward uts.side to the :core and :liveobjects UTS tasks
sacOO7 107ab17
Clean up build and CI leftovers
sacOO7 17d9fda
Cover release() in the remaining channel states (RTS4c-e)
sacOO7 a33b1f6
Derive the agent version in RealtimeHttpHeaderTest
sacOO7 b9d81bc
Point the uts-to-kotlin skill at the 2.0 packages and modules
sacOO7 041e037
Correct details in the migration guide and UTS docs
sacOO7 58ae236
Describe the Ably-Agent entry order accurately in the migration guide
sacOO7 29dd929
Correct the wrapper-proxy and endpoint Javadoc
sacOO7 aca0297
Keep the idempotentRestPublishing option name
sacOO7 0fa250a
Restructure the README for the 2.0 device and server packages
sacOO7 25a3f80
Drop the version-placeholder note from the README install section
sacOO7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| { | ||
| "_comment": "Maps each UTS spec module (a dir under specification/uts/) to its target test directory per tier. Each tier value is ONE repo-root-relative path (never machine-absolute); the Kotlin package is the path after 'src/test/kotlin/' with '/' -> '.'; the owning Gradle module is the path's first segment (lib/ -> :java, liveobjects/ -> :liveobjects, uts/ -> :uts). Every tier path MUST keep a module segment after the tier (e.g. 'unit/realtime', never bare 'unit') so a derived package can never collide with a :uts smoke package (io.ably.lib.uts.unit / .integration.standard / .integration.proxy) — an invariant currently held only by construction. An optional 'notes' field points (relative to this skill dir) to a per-module ably-js -> ably-java translation reference, read before translating that module. Used by the uts-to-kotlin skill (scripts/resolve_uts.py).", | ||
| "_comment": "Maps each UTS spec module (a dir under specification/uts/) to its target test directory per tier. Each tier value is ONE repo-root-relative path (never machine-absolute); the Kotlin package is the path after 'src/test/kotlin/' with '/' -> '.'; the owning Gradle module is the path's first segment (lib/ -> :core, liveobjects/ -> :liveobjects, uts/ -> :uts). Every tier path MUST keep a module segment after the tier (e.g. 'unit/realtime', never bare 'unit') so a derived package can never collide with a :uts smoke package (io.ably.pubsub.uts.unit / .integration.standard / .integration.proxy) — an invariant currently held only by construction. An optional 'notes' field points (relative to this skill dir) to a per-module ably-js -> ably-java translation reference, read before translating that module. Used by the uts-to-kotlin skill (scripts/resolve_uts.py).", | ||
| "packages": { | ||
| "realtime": { | ||
| "unit": "lib/src/test/kotlin/io/ably/lib/uts/unit/realtime", | ||
| "integration": "lib/src/test/kotlin/io/ably/lib/uts/integration/standard/realtime", | ||
| "proxy": "lib/src/test/kotlin/io/ably/lib/uts/integration/proxy/realtime" | ||
| "unit": "lib/src/test/kotlin/io/ably/pubsub/uts/unit/realtime", | ||
| "integration": "lib/src/test/kotlin/io/ably/pubsub/uts/integration/standard/realtime", | ||
| "proxy": "lib/src/test/kotlin/io/ably/pubsub/uts/integration/proxy/realtime" | ||
| }, | ||
| "objects": { | ||
| "unit": "liveobjects/src/test/kotlin/io/ably/lib/liveobjects/uts/unit", | ||
| "integration": "liveobjects/src/test/kotlin/io/ably/lib/liveobjects/uts/integration", | ||
| "proxy": "liveobjects/src/test/kotlin/io/ably/lib/liveobjects/uts/proxy", | ||
| "unit": "liveobjects/src/test/kotlin/io/ably/pubsub/liveobjects/uts/unit", | ||
| "integration": "liveobjects/src/test/kotlin/io/ably/pubsub/liveobjects/uts/integration", | ||
| "proxy": "liveobjects/src/test/kotlin/io/ably/pubsub/liveobjects/uts/proxy", | ||
| "notes": "references/objects-mapping.md" | ||
| }, | ||
| "rest": { | ||
| "unit": "lib/src/test/kotlin/io/ably/lib/uts/unit/rest", | ||
| "integration": "lib/src/test/kotlin/io/ably/lib/uts/integration/standard/rest", | ||
| "proxy": "lib/src/test/kotlin/io/ably/lib/uts/integration/proxy/rest" | ||
| "unit": "lib/src/test/kotlin/io/ably/pubsub/uts/unit/rest", | ||
| "integration": "lib/src/test/kotlin/io/ably/pubsub/uts/integration/standard/rest", | ||
| "proxy": "lib/src/test/kotlin/io/ably/pubsub/uts/integration/proxy/rest" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: ably/ably-pubsub-java
Length of output: 5960
Script executed:
Repository: ably/ably-pubsub-java
Length of output: 40915
Correct the client type in the REST-fixture paragraph.
The paragraph says the helper "still uses only the public
AblyRest". The helper does not useAblyRest. It builds its client withHttpClientFactory.create(...), which returnsPubSubHttpClient.AblyRestis no longer public, so a contributor who follows this paragraph can select a removed type.📝 Suggested fix