Skip to content

Use a JAVA_VERSION variable in all workflows - #106

Merged
ThoSap merged 4 commits into
mainfrom
use-java-version-env-in-dependency-submission
Nov 13, 2026
Merged

ThoSap merged 4 commits into
mainfrom
use-java-version-env-in-dependency-submission

Conversation

@ThoSap

@ThoSap ThoSap commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Why

The other Gradle projects set the Java version once per workflow, in a workflow-level JAVA_VERSION variable. This makes the workflows of this repository the same.

What changed

Every workflow that sets the Java version declares a workflow-level JAVA_VERSION: 25 and passes ${{ env.JAVA_VERSION }} to its setup action. The values stay the same.

Review notes

  • release.yml and test.yml each declare their own JAVA_VERSION: GitHub does not pass a caller's workflow-level env to a reusable workflow, and with: of a call has no env context.
Test scope
  • No workflow ran on this branch: the dependency submission runs only on main or by hand, and the release workflow only by hand.
Risk: needs a human review, assessed at 5b0235d
  • Every changed file had a full review, with a second opinion from GPT (gpt-6.1-sol), and no finding is open.
  • The repository runs no freshness Action, so the PR gets no risk:low label.

@ThoSap ThoSap self-assigned this Nov 13, 2026
Assisted-by: Claude:claude-opus-5-5
@ThoSap ThoSap changed the title Use a JAVA_VERSION variable in the dependency submission workflow Use a JAVA_VERSION variable in the dependency submission workflow Nov 13, 2026
Assisted-by: Claude:claude-opus-5-5
@ThoSap ThoSap changed the title Use a JAVA_VERSION variable in the dependency submission workflow Use a JAVA_VERSION variable in all workflows Nov 13, 2026
@ThoSap
ThoSap marked this pull request as ready for review November 13, 2026 17:48
@ThoSap
ThoSap merged commit b0a2ee5 into main Nov 13, 2026
4 checks passed
@ThoSap
ThoSap deleted the use-java-version-env-in-dependency-submission branch November 13, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant