Repository navigation
Use a JAVA_VERSION variable in all workflows - #106
Merged
Merged
Conversation
Assisted-by: Claude:claude-opus-5-5
Assisted-by: Claude:claude-opus-5-5
JAVA_VERSION variable in the dependency submission workflow
Assisted-by: Claude:claude-opus-5-5
JAVA_VERSION variable in the dependency submission workflowJAVA_VERSION variable in all workflows
ThoSap
marked this pull request as ready for review
November 13, 2026 17:48
Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The other Gradle projects set the Java version once per workflow, in a workflow-level
JAVA_VERSIONvariable. This makes the workflows of this repository the same.What changed
Every workflow that sets the Java version declares a workflow-level
JAVA_VERSION: 25and passes${{ env.JAVA_VERSION }}to its setup action. The values stay the same.Review notes
release.ymlandtest.ymleach declare their ownJAVA_VERSION: GitHub does not pass a caller's workflow-levelenvto a reusable workflow, andwith:of a call has noenvcontext.Test scope
mainor by hand, and the release workflow only by hand.Risk: needs a human review, assessed at 5b0235d
risk:lowlabel.