Repository navigation
Conversation
ZPascal
marked this pull request as draft
October 26, 2026 19:03
ZPascal
force-pushed
the
fix/review-findings
branch
from
October 26, 2026 19:07
73ee3f9 to
dd18af1
Compare
ZPascal
force-pushed
the
fix/review-findings
branch
from
October 26, 2026 21:51
dd18af1 to
38fc04d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start.sh: no more executing input as commands, quotedcd, push args built with"$@", remote URL resolved once (fixesdirectoryvalues containing spaces).tests/unit.sh(fakegit, asserts on flags) andtests/e2e.sh(real git against a local bare repo viainsteadOf), plus aTestsworkflow with shellcheck.http.extraheaderinGIT_CONFIG_*env instead of being embedded in the remote URL (no longer in process args or git error output).push_only_tagsnow never pushes the branch, also withoutforce_with_lease(matches the documented behavior).start.jsexits with1instead of-1(255).Behavior changes to review
push_only_tags: truewithoutforce_with_leasepreviously also pushedHEAD:<branch>.actions/checkoutpersisted; not reset.Test plan
bash tests/unit.sh(38 pass)bash tests/e2e.sh(17 pass)shellcheckin CI (not run locally)