Repository navigation
Correct the SocketPool docs about one pool and connecting - #11706
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anecdata
reviewed
Nov 1, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dhalbert
approved these changes
Nov 1, 2026
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
This is fine. It's a convenience that there can be multiple pool objects, but it appears that there is no practical difference between them. I could imagine that different pools might be created locally in code so they don't have to be passed around or something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Docs only: several pools are allowed, and a pool can be created before connecting.
Why
Fixes #9481.
The pool object holds no state on any port.
A one-pool rule would only break working code.
Testing
make_newalways allocateshttpserver_simpletest_manual_ap.pydoes itStrict docs build passes. No hardware run.
AI assistance
Written with Claude Code, which ran the desktop lab tests and the docs build and read the port source.
🤖 Generated with Claude Code