Repository navigation
Conversation
dhalbert
requested changes
Nov 7, 2026
Author
Not sure how to not get it to do that. I ran pre-commit locally which might have been responsible for the massive changes. I'll revert the changed files and hopefully only include the bare minimum for this. |
skerr92
force-pushed
the
pixelwing-esp32s3
branch
from
November 7, 2026 23:52
46e22a5 to
31c8f14
Compare
Collaborator
It looks like that wasn't needed, but the way to do it is to do |
dhalbert
marked this pull request as draft
November 8, 2026 14:09
Collaborator
|
I made this draft until the PID is approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested this on my Kavrous Technologies PixelWing ESP32-S3 evaluation board. Awaiting approval for the USB PID on PID Codes for this. pidcodes/pidcodes.github.com#1361