Repository navigation
feat: let AIO_RELOAD_ENV_ON_PRE_HOOKS take a list of hooks - #947
Open
iivvaannxx wants to merge 1 commit into
Open
iivvaannxx wants to merge 1 commit into
iivvaannxx wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AIO_RELOAD_ENV_ON_PRE_HOOKSaccepts a comma-separated list of hook names.reloadEnvOnPreHooksnow receives the name of the hook that just ran, and one helper decides if the variable applies to it.Call sites in
build.js,deploy.js,run.js,undeploy.js,lib/build-actions.jsandlib/deploy-actions.jspass their hook name.isEnvEnabledForHookis exported fromapp-helper.jsso other variables can use the same list syntax.Evidence
AIO_RELOAD_ENV_ON_PRE_HOOKS=pre-app-buildreloads after every pre hook.After: it reloads only after
pre-app-build. The helper tests cover off, all, list, a mixed value, and case and spaces. Each command and lib test now also asserts the hook name passed.npm testand eslint pass.Merge Danger
Door: two-way
Blast Radius: env var parsing
A value that contains a known hook name now selects only those hooks. Before, any value other than empty,
0orfalsemeant all. Someone who set the variable to a hook name by accident gets less reloading than before.1,trueand any value with no known hook name behave as before.