Skip to content

Fix Kodiak notification branch filter - #855

Open
chetan2002 wants to merge 1 commit into
adobe:masterfrom
chetan2002:chaggarwal-adobe-cli-kodiak-branch-filter
Open

chetan2002 wants to merge 1 commit into
adobe:masterfrom
chetan2002:chaggarwal-adobe-cli-kodiak-branch-filter

Conversation

@chetan2002

Copy link
Copy Markdown

Description

Change the Jira notification branch filter from the scalar master to a block list containing master.

Related Issue

Related Jira epic: APPBLD-4876.

Motivation and Context

Kodiak's configuration validator requires the branch filter to be a list.

How Has This Been Tested?

  • git diff --check — passed.
  • ruby -e 'require "yaml"; base = IO.popen(["git", "show", "origin/master:.kodiak/config.yaml"], &:read); changed = File.read(".kodiak/config.yaml"); expected = base.sub(" branch: master\n", " branch:\n - master\n"); abort "Unexpected text change" unless expected != base && changed == expected; original = YAML.safe_load(base); actual = YAML.safe_load(changed); original.fetch("notifications").fetch("jira").fetch("default").fetch("filters").fetch("include")["branch"] = ["master"]; abort "Unexpected configuration change" unless original == actual; puts "YAML syntax and exact configuration change verified"' — passed on macOS.
  • The parent investigation reported that Kodiak's live validator rejected the unchanged configuration and accepted this one-field change with Notifications enabled and SBOM disabled. Ticket creation and service attribution were not verified.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov

codecov Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants