Repository navigation
Preserve UDP benchmark diagnostics and opt-in ping timeout controls - #565
Draft
NikolayChirkov wants to merge 8 commits into
Draft
NikolayChirkov wants to merge 8 commits into
NikolayChirkov wants to merge 8 commits into
Conversation
Route errored GetQueuedCompletionStatus results to the registered socket callback instead of dropping them in the poller loop.
Use a 65536-byte receive buffer so overlapped UDP recv can hold full datagrams beyond the 1200 B send MTU preference without WSAEMSGSIZE disconnects. Co-authored-by: Cursor <cursoragent@cursor.com>
When AE_BENCH_PING_MIN_TIMEOUT_MS is positive, avoid emplace that cancels in-flight pings; reschedule Start after success via scheduler. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Цель
Сохранить оставшиеся изменения UDP-бенчмарков в main перед очисткой экспериментальных веток. Пока draft: объединённая Windows-сборка не проверена.
Проверенные исходные точки
10d884ba3dd19183388b8baf96324b64803791049468f5682e718a5af00dc193150a0f8885626455Что сохранить
AE_BENCH_CONNECTION_EVENT_DIAG.AE_BENCH_PING_MIN_TIMEOUT_MSс production default 0; сохранение pending ping при включённом экспериментальном floor.Windows IOCP, 65536-byte UDP receive buffer, SO_SNDBUF opt-in и large-datagram opt-in уже внесены в main коммитом
10d884b; не дублировать и не откатывать их. Сохранить актуальные изменения quarantine/reconcile из main.До merge
win_udp_socket.cpp: блок large-UDP используетstd::ofstream/CRT allocation functions, но<fstream>/<cstdlib>подключены только приAE_BENCH_WIN_UDP_SNDBUF_BYTES. Проверить large-UDP-only сборку без SO_SNDBUF.Статус проверки
Статический аудит опубликованного кода выполнен частично. Локальные незапушенные файлы, Windows build и тесты объединённого дерева в этой проверке недоступны; PASS не заявляется.