Repository navigation
DO-1766: Install safe-chain in all workflows that install npm packages - #191
Closed
tmthrgd-aligent wants to merge 1 commit into
Closed
tmthrgd-aligent wants to merge 1 commit into
tmthrgd-aligent wants to merge 1 commit into
Conversation
Add the existing "Install safe-chain" step before the first package install in every job that runs npm/yarn/pnpm (including global CLI installs and the Adobe I/O CLI setup action), matching the step already used in node-pr, node-publish, aws-cdk, nx-serverless-deployment, shopify-deploy and the Vercel deploy workflows. Not covered: safe-chain only supports npm- and PyPI-based package managers, so it cannot protect the following: - php-quality-checks.yml (Composer): not supported by safe-chain. Composer 2.10+ blocks malicious packages by default using Aikido's threat feed via Packagist. The workflow installs composer:v2 through setup-php, which should resolve to the latest 2.x; pinning composer:2.10 or higher would guarantee this protection. - aem-sync-to-cloudmanager-repo.yml (Maven): not supported by safe-chain. Aikido only covers Maven via its separate paid Device Protection product. - magento-cloud-deploy.yml: installs the Magento Cloud CLI via `curl | php`, which no package manager tooling intercepts. Refs: - https://github.com/AikidoSec/safe-chain - https://aikido.dev/blog/composer-protected-aikido-packagist Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
Contributor
Author
|
Closing in favour of #193. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the existing "Install safe-chain" step before the first package install in every job that runs npm/yarn/pnpm (including global CLI installs and the Adobe I/O CLI setup action), matching the step already used in node-pr, node-publish, aws-cdk, nx-serverless-deployment, shopify-deploy and the Vercel deploy workflows.
Not covered: safe-chain only supports npm- and PyPI-based package managers, so it cannot protect the following:
curl | php, which no package manager tooling intercepts.Refs:
Description of the proposed changes
Screenshots (if applicable)
Other solutions considered (if any)
Notes to PR author
Notes to reviewers
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback
Time Tracking
ABC-xxx: code review, select project XXXX