Repository navigation
build: update dependency chokidar to v6 - #34466
Open
alan-agius4 wants to merge 1 commit into
Open
alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
See associated pull request for more information. Closes angular#34464 as a pr takeover
angular-robot
Bot
added
the
area: build & ci
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the chokidar dependency from version 5.0.0 to 6.0.0. To accommodate Chokidar 6's behavior of keeping ancestor directories of explicitly watched package files un-ignored, the file watcher utility in packages/angular/build/src/utils/watcher.ts has been updated. Specifically, a new helper isNodeModulesSegment was introduced, isPathWatched was optimized to stop traversing when reaching a node_modules segment, and the ignore logic in createChokidarIgnored was adjusted to correctly prune unwatched descendants inside node_modules. There are no review comments to address, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34464 as a pr takeover