Repository navigation
Conversation
…component `ng generate module --route` generates a component and references it from the routing module template by its default file and class name (`./foo`, `Foo`). The component inherited the workspace `type` option, so in workspaces that set it (e.g. after updating to v20) the component was generated as `foo.component.ts` and the routing module import failed to resolve. Pass an empty `type`, as the library and app-shell schematics do. Fixes angular#34449
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request ensures that when generating a module, the nested component does not inherit a type from the workspace defaults, preventing broken route templates. A corresponding unit test has been added. A review comment suggests using the public engine property instead of accessing the private _engineHost property in the test to register the options transform, which improves type safety and avoids relying on private implementation details.
alan-agius4
self-requested a review
October 22, 2026 11:14
alan-agius4
added
target: minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ng generate module --routegenerates a component and references it from the routing module template by its default file and class name (./foo,Foo). The component inherited the workspacetypeoption, so in workspaces that set it (e.g. after updating to v20) the component was generated asfoo.component.tsand the routing module import failed to resolve.Pass an empty
type, as the library and app-shell schematics do.Fixes #34449