Repository navigation
Conversation
npm only warns when a dependency's `engines` doesn't match the installed Node.js version, while Yarn and pnpm fail. Generate an `.npmrc` with `engine-strict=true` for new workspaces that use npm, so installs with an unsupported Node.js version fail instead of printing an easy-to-miss warning. Closes angular#31271
angular-robot
Bot
added
detected: feature
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures the workspace schematic to generate an .npmrc file with engine-strict=true when npm is selected as the package manager. This ensures that npm strictly enforces engine version requirements, matching the default behavior of other package managers like yarn, pnpm, and bun. Corresponding unit tests have been added to verify this behavior. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm only warns when a dependency's
enginesdoesn't match the installed Node.js version, while Yarn and pnpm fail. Generate an.npmrcwithengine-strict=truefor new workspaces that use npm, so installs with an unsupported Node.js version fail instead of printing an easy-to-miss warning.Closes #31271