Repository navigation
feat: support KeyboardEvent - #59
Merged
Merged
Conversation
- Add KeyboardEvent implementation extending UIEvent.
- Expose KeyboardEvent on domino.impl and in events.js.
- Support createEvent('KeyboardEvent') and aliases in Document.js.
- Remove KeyboardEvent from web-platform-tests blocklist.
Member
Author
|
Note, here's the breakage angular/angular#72023 |
alan-agius4
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following #58,
domino.impl.Eventpoints to Node's nativeEventconstructor in Node.js 18+.Because Node does not provide a global
KeyboardEvent,@angular/platform-serverpreviously aliasedKeyboardEvent = domino.impl.Event. Withdomino.impl.Eventbeing Node's nativeEvent, constructingnew KeyboardEvent(type, { key, code, ... })silently dropped all keyboard-specific dictionary properties, which broke Angular key event tests.Changes
KeyboardEventimplementation extendingUIEvent.KeyboardEventinlib/events.jsand ondomino.impl.keyboardeventandkeyeventstoDocument.jsto supportcreateEvent('KeyboardEvent').createEvent('KeyboardEvent')fromtest/web-platform-blocklist.json.KeyboardEventintest/domino.js.