Repository navigation
feat: Queue client-mode scene updates and skip the rebuild for data-only updates - #202
Draft
LKasianAnsys wants to merge 3 commits into
Draft
LKasianAnsys wants to merge 3 commits into
LKasianAnsys wants to merge 3 commits into
Conversation
LKasianAnsys
changed the base branch from
feat/geometry-picker-for-server-mode
to
main
November 3, 2026 16:34
LKasianAnsys
changed the base branch from
main
to
feat/geometry-picker-for-server-mode
November 3, 2026 16:34
LKasianAnsys
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #192
We would like the client and server modes to share a mechanism for geometry picking. This introduces a round trip from the client to the server on every geometry pick. Until now, every server push in client mode applied its update to the wasm scene and then rebuilt the frontend, and the pushes could overlap. With this PR, updates now run one in series, and pushes that arrive during one merge into a single pending update, which rebuilds once if any of them was structural.
An update sent with
dataOnlyis applied and redrawn without rebuilding the frontend. A failed update still skips its rebuild and does not block the next one.This is a change in client-mode only; server mode should be unaffected.