Repository navigation
feat: Reuse the rendering-mode probe connection in client mode - #203
Draft
LKasianAnsys wants to merge 2 commits into
Draft
LKasianAnsys wants to merge 2 commits into
LKasianAnsys wants to merge 2 commits into
Conversation
LKasianAnsys
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #192
When a VISOR session is loaded in the browser, the app opens a Trame connection to ask the server which rendering mode it is running in (the rendering-mode probe). it then starts the client or server viewer.
Server mode keeps using that connection. Until now, client mode disconnected it and opened a second connection for the WASM scene. The probe's
beforeunloadlistener then called the closed socket on every refresh, and its socket closed on a deleted object, logging two errors.With this PR, client mode now passes the probe's open connection to the viewer, so client mode now uses a single connection, as server mode already does, and the mode is read from the probe's
modeonly. Server mode is unchanged.