Repository navigation
feat: Pick and highlight geometry through the server in client mode - #204
Draft
LKasianAnsys wants to merge 6 commits into
Draft
LKasianAnsys wants to merge 6 commits into
LKasianAnsys wants to merge 6 commits into
Conversation
github-actions
Bot
added
test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #192
Geometry picking currently has two separate implementations for client and server mode. Until now, the client mode picked geometry in WASM and drew the highlight on a narrow canvas overlay. In this PR, the client mode geometry picking and highlighting is updated to share the same implementation as the server mode. Client mode now asks the server to set and clear the highlight, which the server draws in the shared scene and pushes as a data-only update; the client reports its pixel ratio so the highlight matches server mode in size, and the overlay is removed.
(This is a WIP; still need to update the client mode to pick through the server picker, and remove the wasm geometry picker)