Skip to content

ci: run sync-info only on dev and keep i18n order stable - #332

Merged
robinv8 merged 1 commit into
devfrom
fix/sync-info-workflow
Oct 22, 2026
Merged

robinv8 merged 1 commit into
devfrom
fix/sync-info-workflow

Conversation

@robinv8

@robinv8 robinv8 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

The Sync Plugin Info workflow ran on pushes to both dev and main while always using the same chore/sync-info branch. A dev run force-pushed that branch onto dev, so the main sync PR (#330) suddenly showed the whole LDAP connector, and two bot PRs (#330, #331) shared one branch. Separately, sync-info.sh iterated i18n files in unsorted find order, so zh_CN/en_US could swap between runs and produce large reorder-only diffs.

Changes:

  • Trigger only on pushes to dev (changes reach main via dev); set base: dev explicitly and delete-branch: true.
  • Add a concurrency group so back-to-back pushes don't race on the branch.
  • Sort i18n files with LC_ALL=C sort so key order is deterministic (en_US, then zh_CN, matching the current file).

Tested locally on dev: the regenerated plugins_desc.json only adds the new LDAP and vector-search entries (+65/−0), with no reordering, and two runs are byte-identical.

@robinv8
robinv8 merged commit a92c394 into dev Oct 22, 2026
@robinv8
robinv8 deleted the fix/sync-info-workflow branch October 22, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant