Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1646
Proposed Changes
The lock is acquired with a no-op update that preserves the score and update timestamp. It is held through the count and final update, so refreshes on the same object wait for each other. SQLite uses its database write lock; PostgreSQL/MySQL use the target row's write lock.
Validation
go test ./internal/repo/activity ./internal/repo/repo_test ./internal/service/content -count=1go test -race ./internal/repo/activity -count=1 -timeout 90sgo build ./...go vet ./...golangci-lint run ./internal/repo/activity/...(0 issues)git diff --checkThe committed tests use SQLite. The same regression tests also passed against a temporary local PostgreSQL 14.2 instance using a test-fixture adapter supplied through Go's
-overlayoption; that adapter is not part of this change. MySQL/MariaDB have not been tested.Related: #1650 proposes another approach to the same issue.