Repository navigation
GH-50229: [C++] Verify Feather V1 metadata before parsing - #54909
Open
xiaobai0529 wants to merge 1 commit into
Open
xiaobai0529 wants to merge 1 commit into
xiaobai0529 wants to merge 1 commit into
Conversation
Run the generated flatbuffers verifier before constructing the CTable view. Malformed metadata now returns Invalid instead of being dereferenced, preventing an out-of-bounds read in the legacy Feather reader. Add a regression test using the 36-byte zero-length-metadata input from the issue.
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
|
|
|
|
xiaobai0529
marked this pull request as ready for review
October 21, 2026 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feather::Reader::Opencallsfbs::GetCTablewith noflatbuffers::Verifier#50229.Root cause
\ReaderV1::Open\ passed attacker-controlled metadata directly to \bs::GetCTable, and \ReadSchema\ then accessed \metadata_->columns()\ before any validation. This caused an out-of-bounds read reported by ASan.
Fixes #50229
Verification
AI assistance
I used an AI coding assistant for investigation and drafting this patch. I reviewed the final diff and the verifier API, and ran the tests above locally.
feather::Reader::Opencallsfbs::GetCTablewith noflatbuffers::Verifier#50229