Repository navigation
filter local policy assertions from ListingAgent ?policy responses - #1321
Merged
robertlazarski merged 1 commit intoOct 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the ?policy route in ListingAgent.handlePolicyRequest now writes the policy through the ExternalPolicySerializer it already builds with AxisConfiguration.getLocalPolicyAssertions() as its filter. the serializer was configured and never used: both the effective-policy branch (GET /services/?policy) and the by-id branch (?policy&id=) called Policy.serialize(XMLStreamWriter) directly, so assertions a module lists under local-policy-assertions in its module.xml (ModuleBuilder: "These assertions are not exposed to the outside") were published anyway. Rampart lists RampartConfig there, and RampartConfig carries the service user, the password callback class and the signature/encryption crypto properties, keystore alias and keystore password included. the route is anonymous for any service whose metadata is exposed, and AxisService2WSDL11, AxisService2WSDL20 and WSDLSerializationUtil already embed policies through this filter, so ?wsdl withheld RampartConfig while ?policy returned it verbatim (CWE-200 / CWE-497). the response is now the normalized form the WSDL embedding uses: the same assertions, minus the local ones. PolicyListingFilterTest attaches a policy carrying a RampartConfig with a keystore password and fails before the change on both branches (the password is in the response) and passes after; the transport-http module build is green (113 tests, rat included).